Fix test data for removing partition_info #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 99.13% 99.13% -0.01%
==========================================
Files 21 21
Lines 464 461 -3
==========================================
- Hits 460 457 -3
Misses 4 4 ☔ View full report in Codecov by Sentry. |
camposandro
approved these changes
Nov 14, 2023
|
There's the linting issues, but apart from that looks good! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is related to work toward deprecating
partition_info.csv(astronomy-commons/hats#147), and is very similar to PR astronomy-commons/hats-import#166Solution Description
The catalog files for the cross matching test data is quite old, and didn't have the Norder/Dir/Npix columns inside the parquet file. When we try to read the directory as a hipscat catalog, we try to create the
PartitionInfofrom the row group statistics for those fields, but fail to do so.This PR re-generates the catalog files, using the current map/reduce methods of the import tool to include the partition info columns as necessary.
While I'm here, I took out the tests for handling catalog directories with no metadata files (since we're going to require them very soon).